Repository navigation
Conversation
getTokenTypeMap() and getRuleIndexMap() update static caches while holding only the per-instance _mutex, so recognizers on different threads race on the same std::map. Use one mutex shared by all recognizers, like the Java runtime which synchronizes on the cache itself. Signed-off-by: obsidian_nomad <abdul@sproutxp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognizer::getTokenTypeMap()andRecognizer::getRuleIndexMap()read and insert into the static_tokenTypeMapCacheand_ruleIndexMapCachewhile holding_mutex, which is a per-instance member. Two lexers or parsers running on separate threads therefore modify the samestd::mapconcurrently and corrupt it. Both are reached throughgetTokenType()andParser::getRuleIndex(), which XPath andParseTreePatternMatcheruse.The new
RecognizerTestcalls both getters from 8 threads on distinct recognizers. On the currentdevit hung or crashed in 7 of 20 runs; with the change it passed 30 of 30, and the full C++ test suite passes.